----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68098/#review206588 -----------------------------------------------------------
Ship it! Looks good, except for two typos in the commit message (`no_base` -> `nobase`, `strucutre` -> `structure`) - Benno Evers On July 29, 2018, 9:46 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68098/ > ----------------------------------------------------------- > > (Updated July 29, 2018, 9:46 p.m.) > > > Review request for mesos, Benno Evers and James Peach. > > > Bugs: MESOS-9115 > https://issues.apache.org/jira/browse/MESOS-9115 > > > Repository: mesos > > > Description > ------- > > The rapidjson headers were getting flattened into the same top-level > include directory. The `no_base` prefix will preserve the directory > strucutre of the headers, however we would need a Makefile further > down for this to work (as done with stout and libprocess). Instead, > we use separate variables as suggested here: > > https://www.gnu.org/software/automake/manual/html_node/Alternative.html > > > Diffs > ----- > > 3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339 > > > Diff: https://reviews.apache.org/r/68098/diff/1/ > > > Testing > ------- > > $ make install DESTDIR=tmp > ... > $ cd tmp/ && find include/ > [bmahler@core-dev local]$ find include > include > include/elfio > include/elfio/elf_types.hpp > include/elfio/elfio.hpp > include/elfio/elfio_dump.hpp > include/elfio/elfio_dynamic.hpp > include/elfio/elfio_header.hpp > include/elfio/elfio_note.hpp > include/elfio/elfio_relocation.hpp > include/elfio/elfio_section.hpp > include/elfio/elfio_segment.hpp > include/elfio/elfio_strings.hpp > include/elfio/elfio_symbols.hpp > include/elfio/elfio_utils.hpp > include/picojson.h > include/rapidjson > include/rapidjson/error > include/rapidjson/error/en.h > include/rapidjson/error/error.h > include/rapidjson/internal > include/rapidjson/internal/biginteger.h > include/rapidjson/internal/diyfp.h > include/rapidjson/internal/dtoa.h > include/rapidjson/internal/ieee754.h > include/rapidjson/internal/itoa.h > include/rapidjson/internal/meta.h > include/rapidjson/internal/pow10.h > include/rapidjson/internal/regex.h > include/rapidjson/internal/stack.h > include/rapidjson/internal/strfunc.h > include/rapidjson/internal/strtod.h > include/rapidjson/internal/swap.h > include/rapidjson/msinttypes > include/rapidjson/msinttypes/inttypes.h > include/rapidjson/msinttypes/stdint.h > include/rapidjson/allocators.h > include/rapidjson/document.h > include/rapidjson/encodedstream.h > include/rapidjson/encodings.h > include/rapidjson/filereadstream.h > include/rapidjson/filewritestream.h > include/rapidjson/fwd.h > include/rapidjson/istreamwrapper.h > include/rapidjson/memorybuffer.h > include/rapidjson/memorystream.h > include/rapidjson/ostreamwrapper.h > include/rapidjson/pointer.h > include/rapidjson/prettywriter.h > include/rapidjson/rapidjson.h > include/rapidjson/reader.h > include/rapidjson/schema.h > include/rapidjson/stream.h > include/rapidjson/stringbuffer.h > include/rapidjson/writer.h > include/stout > ... > > > Thanks, > > Benjamin Mahler > >
