----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68120/#review206652 -----------------------------------------------------------
src/webui/app/controllers.js Lines 515 (patched) <https://reviews.apache.org/r/68120/#comment289721> This is the first time we use a ternary operator in this file but we use some in `app.js` and it makes sense to use it here. - Armand Grillet On July 31, 2018, 2:40 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68120/ > ----------------------------------------------------------- > > (Updated July 31, 2018, 2:40 a.m.) > > > Review request for mesos, Armand Grillet and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > This path pulls up the leader URL prefix generation to a top-level > function in order to have it re-used across controllers. > > Having this logic in just one place makes it easier to modify it, > e.g., to make it possible to use the UI via a reverse proxy. > > > Diffs > ----- > > src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b > src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc > > > Diff: https://reviews.apache.org/r/68120/diff/1/ > > > Testing > ------- > > manual testing > > > Thanks, > > Benjamin Mahler > >
