----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68325/ -----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos Description ------- When `EXPECT_DISPATCH` was originally introduced in de8e10830d178a7c, the pid was added to `DispatchEvent` rather than being passed through the filter API. This adds a performance overhead (we must perform an unnecessary `UPID` copy construction / destruction for every dispatch), and it also requires that we inject the `UPID` into additional events (for example, if we wanted to introduce `FUTURE_EXITED`, we need to add the UPID into `ExitedEvent`). Rather than continue this trend, we can instead pass the Process `UPID` through the filter API so that the client knows which Process the event belongs to. This also lets us remove the `UPID` copy construction / destruction cost from `DispatchEvent`, which should provide a minor performance benefit. Diffs ----- 3rdparty/libprocess/include/process/event.hpp d96db74e70efa2bb824f575b0e9c965e2cd4af39 3rdparty/libprocess/include/process/filter.hpp 79a19175af1964ca6b6fd415f4dfb9b9d9d0e3e0 3rdparty/libprocess/include/process/gmock.hpp e30f5863d3d028fa320ca4b674a6c7a499c15991 3rdparty/libprocess/src/process.cpp 23f7ce8651009f9319f4ae4681816bec0217fa31 Diff: https://reviews.apache.org/r/68325/diff/1/ Testing ------- make check Thanks, Benjamin Mahler
