----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review207200 -----------------------------------------------------------
Patch looks great! Reviews applied: [67931, 67930, 67984, 67932] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 6, 2018, 6:46 p.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67932/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2018, 6:46 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, > Jie Yu, Joseph Wu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > The `tar` command cannot work successfully on Windows, so we use > `wclayer` instead. Note that the folder generated from extraction also > cannot be deleted by `rmdir`, so the GC is also changed to use > `wclayer remove`. > > > Diffs > ----- > > src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc > src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 60507aa1b7951666ed758d1b3800eddd67ba7be6 > > > Diff: https://reviews.apache.org/r/67932/diff/9/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > >