> On Aug. 14, 2018, 7:30 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/secret.cpp > > Lines 287 (patched) > > <https://reviews.apache.org/r/68219/diff/2/?file=2069915#file2069915line287> > > > > Why not the same order as previous patches? I guess it does not hurt
Agree, let me make it the same order as the previous patches. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68219/#review207185 ----------------------------------------------------------- On Aug. 7, 2018, 10:22 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68219/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2018, 10:22 p.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. > > > Bugs: MESOS-8814 > https://issues.apache.org/jira/browse/MESOS-8814 > > > Repository: mesos > > > Description > ------- > > Updated `volume/secret` isolator to honor volume mode. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/volume/secret.cpp > 663aafc7173667f8f78b26bdc824a3ab2e04ed25 > > > Diff: https://reviews.apache.org/r/68219/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
