> On Aug. 18, 2018, 12:34 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 7684-7690 (original) > > <https://reviews.apache.org/r/68362/diff/4/?file=2074583#file2074583line7684> > > > > Where do we update the operations and total resources?
The `if` statement removed here was for the case where a resource provider was unknown when the `UPDATE_STATE` was received. This is not possible anymore as we always inform the master a resource provider subscribes. The code handling _updates_ to total resource or operations was in the `else` block previously which will be always executed now. Dropping. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68362/#review207565 ----------------------------------------------------------- On Aug. 15, 2018, 3:53 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68362/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2018, 3:53 p.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > With the introduction of the resource provider `SUBSCRIBE` event which > contains the full `ResourceProviderInfo` of a subscribed resource > provider, we can avoid sending the `ResourceProviderInfo` in > `UPDATE_STATE` events and instead only send a `ResourceProviderID` > like in most other messages. > > > Diffs > ----- > > src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620 > src/resource_provider/message.hpp 9307f8859035dfafe0952e9026b078b44121537e > src/slave/slave.cpp 679394a549cdfe84d64a102164c8652ad96f1eb2 > src/tests/resource_provider_manager_tests.cpp > 0b9e985cf3b4ded8590615b418e52a2a11f1c1aa > > > Diff: https://reviews.apache.org/r/68362/diff/5/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
