> On Aug. 20, 2018, 8:18 nachm., Andrew Schwartzmeyer wrote:
> > I have to ask: why? I've personally thought it would be nicer to remove 
> > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add 
> > it to stout and libprocess?

Thanks for engaging. The main idea would be to make the various binaries easier 
to run, e.g., when manually executing tests. IMO the alternative to the patches 
proposed here would be to all put them into a shared, _global_ folder -- many 
projects use bin/ for that.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68319/#review207624
-----------------------------------------------------------


On Aug. 20, 2018, 11:53 vorm., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68319/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2018, 11:53 vorm.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Put binaries into root folder in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/CMakeLists.txt 5bba8e2c59ea3d7c37d186a2273bcaad6ffb5c46 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> a03a77eb5e289b4daac0bbd414dc17c8acc848dc 
> 
> 
> Diff: https://reviews.apache.org/r/68319/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to