----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68564/#review208169 -----------------------------------------------------------
Fix it, then Ship it! configure.ac Lines 639 (patched) <https://reviews.apache.org/r/68564/#comment291943> If you implement https://reviews.apache.org/r/68576/#comment291938 this would be another candidate to be moved to a more general place. The code here should be robust enough to support that. - Benjamin Bannier On Aug. 30, 2018, 11:11 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68564/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2018, 11:11 p.m.) > > > Review request for mesos, Benjamin Bannier and James Peach. > > > Bugs: MESOS-9193 > https://issues.apache.org/jira/browse/MESOS-9193 > > > Repository: mesos > > > Description > ------- > > Clang 3.5 does not support `-Wno-inconsisent-missing-override` so we > only add it if the tool chain supports this option. > > > Diffs > ----- > > configure.ac e4fbd8cab04707c1fe0c6d5ade7b7a7dca9a7cb7 > > > Diff: https://reviews.apache.org/r/68564/diff/3/ > > > Testing > ------- > > make with clang 3.5.0/3.6.0. > > > Thanks, > > Chun-Hung Hsiao > >
