----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68236/#review208405 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On Sept. 3, 2018, 4:58 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68236/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2018, 4:58 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-9116 > https://issues.apache.org/jira/browse/MESOS-9116 > > > Repository: mesos > > > Description > ------- > > Previously, we sent `ATTACH_CONTAINER_OUTPUT` to attach to a > short-living nested container. An attempt to attach to a terminated > nested container leads to HTTP 500 error. This patch gets rid of > `ATTACH_CONTAINER_OUTPUT` in favor of `LAUNCH_NESTED_CONTAINER_SESSION` > so that we can read the container's output without using an extra call. > > > Diffs > ----- > > src/tests/api_tests.cpp 43541af732df271177f0fd56ddc419adec461110 > > > Diff: https://reviews.apache.org/r/68236/diff/1/ > > > Testing > ------- > > 1. sudo make check (Fedora 25) > 2. internal CI > > > Thanks, > > Andrei Budnik > >
