----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68538/#review208487 -----------------------------------------------------------
We also need to updated `support/mesos-tidy/Dockerfile`. I have updated the Dockerfile a little below, add the same Python 3 installation as in the already changed Dockerfile. ``` # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # http://www.apache.org/licenses/LICENSE-2.0 # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. FROM ubuntu:16.04 MAINTAINER The Apache Mesos Developers <d...@mesos.apache.org> WORKDIR /tmp/build # Build Mesos-flavored `clang-tidy`. RUN apt-get update && \ apt-get install -qy --no-install-recommends \ build-essential \ ca-certificates \ curl \ git \ python-dev && \ apt-get clean # Mesos requires at least cmake-3.7.0 on Linux and cmake-3.8.0 on Windows. # # TODO(abudnik): Skip this step when a newer version of CMake package is # available in OS repository. RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh \ -o /tmp/install-cmake.sh && \ sh /tmp/install-cmake.sh --skip-license --prefix=/usr/local RUN \ git clone --depth 1 -b release_60 http://llvm.org/git/llvm /tmp/llvm && \ git clone --depth 1 -b mesos_60 http://github.com/mesos/clang.git /tmp/llvm/tools/clang && \ git clone --depth 1 -b mesos_60 http://github.com/mesos/clang-tools-extra.git /tmp/llvm/tools/clang/tools/extra && \ \ cmake /tmp/llvm -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/opt && \ cmake --build tools/clang/lib/Headers --target install -- -j $(nproc) && \ cmake --build tools/clang/tools/extra/clang-tidy --target install -- -j $(nproc) && \ \ cd / && \ rm -rf /tmp/llvm && \ rm -rf /tmp/build ENV PATH /opt/bin:$PATH # Install Mesos dependencies RUN apt-get update && \ apt-get install -qy \ autoconf \ libacl1-dev \ libapr1-dev \ libcurl4-nss-dev \ libsasl2-dev \ libsasl2-modules \ libsvn-dev \ libtool \ zlib1g-dev && \ apt-get clean # Install `jq` and `parallel` for `clang-tidy` invocation. RUN apt-get update && \ apt-get install -qy \ jq \ parallel && \ apt-get clean # Wire up the script which performs the actual work. WORKDIR /BUILD ADD ["entrypoint.sh", "entrypoint.sh"] CMD exec ./entrypoint.sh ``` - Armand Grillet On Sept. 7, 2018, 6:55 p.m., Robin Gögge wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68538/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2018, 6:55 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, and Kevin > Klues. > > > Bugs: MESOS-8957 > https://issues.apache.org/jira/browse/MESOS-8957 > > > Repository: mesos > > > Description > ------- > > Following the update of the CLI to Python 3, we embed Python 3.6 > (the minimum required Python version) to the docker images used > during continuous integration. > > > Diffs > ----- > > support/mesos-build/centos-7.dockerfile > 068f946f8410772afd9aa45c6f864e475efe84c9 > support/mesos-build/ubuntu-16.04-arm.dockerfile > 352156fb14d90a4b248bc5d15f1d0127bec00161 > support/mesos-build/ubuntu-16.04.dockerfile > 503b2e370b9222a0e92b8d5db2b08256df3adef8 > > > Diff: https://reviews.apache.org/r/68538/diff/3/ > > > Testing > ------- > > For each of the docker files I have built the docker image and ran > `PYTHON=python3 src/python/cli_new/bootstrap`. > > > Thanks, > > Robin Gögge > >
