----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65168/#review208563 -----------------------------------------------------------
src/slave/containerizer/mesos/io/switchboard.cpp Line 1224 (original), 1230 (patched) <https://reviews.apache.org/r/65168/#comment292613> no "a" src/slave/http.cpp Lines 3152-3153 (patched) <https://reviews.apache.org/r/65168/#comment292612> fits one line - Alexander Rukletsov On Sept. 6, 2018, 3:22 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65168/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2018, 3:22 p.m.) > > > Review request for mesos, Alexander Rukletsov and Qian Zhang. > > > Bugs: MESOS-8545 > https://issues.apache.org/jira/browse/MESOS-8545 > > > Repository: mesos > > > Description > ------- > > Previously, IOSwitchboard process could terminate before all HTTP > responses had been sent to the agent. In the case of > `ATTACH_CONTAINER_INPUT` call, we could drop a final HTTP `200 OK` > response, so the agent got broken HTTP connection for the call. > This patch introduces an acknowledgment for the received response > for the `ATTACH_CONTAINER_INPUT` call. This acknowledgment is a new > type of control messages for the `ATTACH_CONTAINER_INPUT` call. When > IOSwitchboard receives an acknowledgment, and io redirects are > finished, it terminates itself. That guarantees that the agent always > receives a response for the `ATTACH_CONTAINER_INPUT` call. > > > Diffs > ----- > > include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 > src/slave/containerizer/mesos/io/switchboard.cpp > 52b0e521ed1c651c90b3a3df7c4df576288bf400 > src/slave/http.hpp 78200874cb03a3d5af4ee0443c03a1d94cd494cc > src/slave/http.cpp fb923686e92ff635e99cc2ccc6316f0282ab3e3a > src/tests/containerizer/io_switchboard_tests.cpp > c00f6a9018801e6b8144ff3beae549c15c7d3917 > > > Diff: https://reviews.apache.org/r/65168/diff/8/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
