> On Sept. 12, 2018, 3:01 p.m., Alexander Rukletsov wrote:
> > src/tests/api_tests.cpp
> > Lines 6766-6784 (patched)
> > <https://reviews.apache.org/r/68230/diff/5/?file=2086190#file2086190line6766>
> >
> > Not yours, but please—for me and my sanity!—let's pull it into a
> > general helper in `tests/mesos.hpp`. Quick grepping shows there are more
> > instances where this helper can be applied (can you even maybe fix those in
> > a separate patch?)
> >
> >
> > https://github.com/apache/mesos/blob/af82f887db535c44b559e0d19cbddfb2dbd6134a/src/tests/master_tests.cpp#L9568-L9586
> >
> > https://github.com/apache/mesos/blob/af82f887db535c44b559e0d19cbddfb2dbd6134a/src/tests/scheduler_tests.cpp#L612-L630
Oh, I found that we can use this code instead (from the default executor test):
```
mesos.send(
v1::createCallAccept(
frameworkId,
offer,
{v1::LAUNCH_GROUP(
executorInfo, v1::createTaskGroupInfo({taskInfo}))}));
```
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68230/#review208560
-----------------------------------------------------------
On Aug. 31, 2018, 1:11 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68230/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 1:11 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang.
>
>
> Bugs: MESOS-9131
> https://issues.apache.org/jira/browse/MESOS-9131
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that IOSwitchboard, which holds an open HTTP input
> connection, terminates once IO redirects finish for the corresponding
> nested container.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 6be0dfa28333a15b1650268798046dd5e76717c5
>
>
> Diff: https://reviews.apache.org/r/68230/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
