----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/#review208594 -----------------------------------------------------------
src/python/lib/mesos/http.py Line 33 (original), 31 (patched) <https://reviews.apache.org/r/68654/#comment292674> Can we set an option in `isort` to keep these imports the same as before? I know that klueska wanted to keep this style. src/python/lib/setup.cfg Lines 1 (patched) <https://reviews.apache.org/r/68654/#comment292672> Let's rename this file `.isort.cfg` according to the otpions offered by https://github.com/timothycrosley/isort/wiki/isort-Settings src/python/lib/tox.ini Lines 22 (patched) <https://reviews.apache.org/r/68654/#comment292673> Let's use the latest version, `4.3.4`. - Armand Grillet On Sept. 6, 2018, 9:37 a.m., Eric Chung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68654/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2018, 9:37 a.m.) > > > Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Enabled isort for src/python/lib. > > > Diffs > ----- > > src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c > src/python/lib/setup.cfg PRE-CREATION > src/python/lib/tests/test_exceptions.py > 096eab82311e02b0fa829101b6ad1b23e42ce088 > src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab > src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 > > > Diff: https://reviews.apache.org/r/68654/diff/1/ > > > Testing > ------- > > > Thanks, > > Eric Chung > >
