----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68728/#review208671 -----------------------------------------------------------
Ship it! Oh, I didn't think to look here =/ Thanks for taking care of it! - Benjamin Mahler On Sept. 17, 2018, 1:28 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68728/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2018, 1:28 a.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Bugs: MESOS-9238 > https://issues.apache.org/jira/browse/MESOS-9238 > > > Repository: mesos > > > Description > ------- > > We didn't update the RPM spec file when we added the rapidjson > dependencies. This will cause RPM build to fail like the following: > > RPM build errors: > error: Installed (but unpackaged) file(s) found: > /usr/include/rapidjson/allocators.h > /usr/include/rapidjson/document.h > ... > > This patch fixed it by adding the rapidjson headers to the %files > section accordingly. > > > Diffs > ----- > > support/packaging/centos/mesos.spec > 053298522ee198b3b23004ff9ce73aa60a39e8a4 > > > Diff: https://reviews.apache.org/r/68728/diff/1/ > > > Testing > ------- > > > Thanks, > > Jie Yu > >
