----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62187/#review208704 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On Sept. 10, 2018, 6 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62187/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2018, 6 p.m.) > > > Review request for mesos, Andrei Budnik and Alexander Rukletsov. > > > Bugs: MESOS-8545 > https://issues.apache.org/jira/browse/MESOS-8545 > > > Repository: mesos > > > Description > ------- > > We force IOSwitchboard to return a final response to the client for the > `ATTACH_CONTAINER_INPUT` call after IO redirects are finished. In this > case, we don't read remaining messages from the input stream. So the > agent might send an acknowledgment for the request before IOSwitchboard > has received remaining messages. We need to delay termination of > IOSwitchboard to give it a chance to read the remaining messages. > Otherwise, the agent might get `HTTP 500` "broken pipe" while > attempting to write the final message. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 52b0e521ed1c651c90b3a3df7c4df576288bf400 > > > Diff: https://reviews.apache.org/r/62187/diff/5/ > > > Testing > ------- > > internal CI (3x times) > > > Thanks, > > Andrei Budnik > >
