> On May 18, 2018, 10:12 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/realpath.hpp > > Lines 68-81 (patched) > > <https://reviews.apache.org/r/65812/diff/6/?file=2024593#file2024593line68> > > > > IN fact, I would consider making `unprocessed` a `vector<string>` > > (which is a result of `tokenize`) > > > > I understand you want to reset `unprocessed` below, you can still do > > one more `tokenize` there to avoid the complex substr logic here.
I tried with a local rewritten version per your suggestion, but it actually turned out to be a bit more complex and added perf overhead to this version. We simply need to split `unprocessed` into 0 up to 2 elements and the logic seems pretty intuitive here. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review203455 ----------------------------------------------------------- On May 17, 2018, 1:07 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65812/ > ----------------------------------------------------------- > > (Updated May 17, 2018, 1:07 a.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Added an overloaded version of `os::realpath` to stout. > > The new `os::realpath` function is used for evaluating real path > within a scoped root directory. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/realpath.hpp > 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 > > > Diff: https://reviews.apache.org/r/65812/diff/6/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
