----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68508/#review209197 -----------------------------------------------------------
Ship it! Can you do a quick benchmark comparison to see if this has a significant impact? src/master/allocator/mesos/hierarchical.hpp Lines 157 (patched) <https://reviews.apache.org/r/68508/#comment293524> If you CHECK this, should you also do a containment check before the subtraction below? - Benjamin Mahler On Sept. 25, 2018, 8:49 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68508/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2018, 8:49 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Bugs: MESOS-9182 > https://issues.apache.org/jira/browse/MESOS-9182 > > > Repository: mesos > > > Description > ------- > > This would simplify the tracking logic regarding > resource allocations in the allocator. See MESOS-9182. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > e09a615979014909e7b88d44e6617fd1476415c5 > src/master/allocator/mesos/hierarchical.cpp > 906fddc48c52ec222b93d15d53edf9680d2cd861 > > > Diff: https://reviews.apache.org/r/68508/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >