----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68919/#review209218 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 10:55 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68919/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2018, 10:55 p.m.) > > > Review request for mesos, Benjamin Bannier and James Peach. > > > Repository: mesos > > > Description > ------- > > Removed unbundling by default for libevent on macOS when using CMake. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake a820c867b41d2120525c5a32128812ae527ffeba > > > Diff: https://reviews.apache.org/r/68919/diff/1/ > > > Testing > ------- > > macos: cmake .. -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON > -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 > -G Ninja && ninja check -j12 > macos: cmake .. -DUNBUNDLED_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON > -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DCMAKE_EXPORT_COMPILE_COMMANDS=1 > -G Ninja && ninja check -j12 > > > Thanks, > > Till Toenshoff > >
