> On Oct. 5, 2018, 2:17 p.m., Till Toenshoff wrote: > > support/mesos-style.py > > Line 229 (original) > > <https://reviews.apache.org/r/68937/diff/1/?file=2094915#file2094915line230> > > > > Why is this not needed anymore?
Ah, now understood -- sorry for the silly question. This "error" is actually expected for anything that isnt matching the current linter. E.g. C++ files given but Python linter running over it. Overall a questionable design but entirely not the target of this RR. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/#review209263 ----------------------------------------------------------- On Oct. 5, 2018, 10:28 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68937/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2018, 10:28 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9056 > https://issues.apache.org/jira/browse/MESOS-9056 > > > Repository: mesos > > > Description > ------- > > Removed output in mesos-style.py when linting goes well. > > > Diffs > ----- > > support/mesos-style.py 4fea6721e8e2cff37e41815c9e434b7c8740bcf8 > > > Diff: https://reviews.apache.org/r/68937/diff/1/ > > > Testing > ------- > > Posted this review request, which uses the script due to the Git hook: > ``` > ? apache-mesos (MESOS-9056) ? git commit -m "Removed output in > mesos-style.py when linting goes well." > Checking 1 Python file > [MESOS-9056 a0c5c6568] Removed output in mesos-style.py when linting goes > well. > 1 file changed, 3 insertions(+), 3 deletions(-) > ``` > > > Thanks, > > Armand Grillet > >
