----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68993/#review209455 -----------------------------------------------------------
Fix it, then Ship it! src/common/http.cpp Lines 1200 (patched) <https://reviews.apache.org/r/68993/#comment293875> Since the outputs of this log line are likely to be used for rudimentary analysis using shell tools like `grep`, `cut`, `awk`, etc., I think it would be good to pick a unit (seconds or milliseconds) and fix the output to that. This way, tools could immediately process and compare the printed durations without having to implement a small parser to convert to a common unit. - Benno Evers On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68993/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2018, 2:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, > Gastón Kleiman, and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Currently we use `logRequest` function to log requests to endpoints > in Mesos `MasterProcess`, `SlaveProcess`, and `FilesProcess`. Each > request is logged when it is first fetched from the actor mailbox. > However this obviously does not allow for logging the request > processing time. > > This patch introduces a `logResponse` function which logs the request > together with the corresponding response status and the time spent > generating the response. > > > Diffs > ----- > > src/common/http.hpp 4f994a0744f098363327b785df56e877c9624e2a > src/common/http.cpp 9070071bbb42703b3f62e0cf50b31da943da015c > > > Diff: https://reviews.apache.org/r/68993/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/68994/ > > > Thanks, > > Alexander Rukletsov > >
