----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209769 -----------------------------------------------------------
PASS: Mesos patch 69075 was successfully built and tested. Reviews applied: `['69075']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2487/mesos-review-69075 - Mesos Reviewbot Windows On Oct. 18, 2018, 11:41 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69075/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2018, 11:41 p.m.) > > > Review request for mesos, Alexander Rukletsov, Armand Grillet, Jie Yu, and > James Peach. > > > Bugs: MESOS-8907 > https://issues.apache.org/jira/browse/MESOS-8907 > > > Repository: mesos > > > Description > ------- > > Modifies the 'curl' invocation that is returning an http::Response, > locking it into HTTP 1.0. Our current HTTP parser is unable to process > HTTP 2 responses. > > HTTP 1.0 was chosen instead of HTTP 1.1 as some supported linux > distributions still come with curl 7.19 which does not support the > '--http1.1' flag. > > With the advent of curl 7.47, HTTPS connections are being enforced > towards HTTP 2 rather aggressively. As a result, our image fetcher > fails when recent curl versions are being used for pulling images from > a registry that supports HTTP 2. > > For allowing all the benefits of HTTP 2 where possible, we do not > adapt any 'curl' invocations that do not attempt to parse headers. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 6b1277f822dcf80d44daa8133b3ecc8c9a34ef07 > > > Diff: https://reviews.apache.org/r/69075/diff/2/ > > > Testing > ------- > > `make check` > `sudo ./bin/mesos-tests.sh > --gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"` > on a system with curl 7.59.0 installed. > > > Thanks, > > Till Toenshoff > >
