----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210000 -----------------------------------------------------------
Fix it, then Ship it! src/tests/fetcher_tests.cpp Lines 105-106 (patched) <https://reviews.apache.org/r/69146/#comment294639> While this solution appears to be the most efficient it also is not entirely consistent with how we do it in other places; Note that `getcwd()` returns the test-sandbox directory after the fixture did its job. ``` path::join(os::getcwd(), "fetcher"); path::join(os::getcwd(), "frameworks"); ``` would be consistent. Alternatively, we could at least do away with one `CHECK_NOTNONE` and pull it in front of these two uses of `sandbox`. - Till Toenshoff On Oct. 24, 2018, 11:12 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69146/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2018, 11:12 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gilbert Song, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Fetcher tests currently rely on some hard-coded paths, > for example, `/tmp/mesos/fetcher` and `/tmp/frameworks`. > Thus fetcher tests could fail if these directories already > exit. This patch adds a helper function `createSlaveFlags()` > to make use of the test sandboxes. The above paths will be > replaced by `fetch/` and `frameworks/` under the sandbox. > > > Diffs > ----- > > src/tests/fetcher_tests.cpp 283238cdda17a94e034baa195bd9d4b57e363b8a > > > Diff: https://reviews.apache.org/r/69146/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
