----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69096/#review210010 -----------------------------------------------------------
Fix it, then Ship it! src/tests/allocator.hpp Lines 40-45 (patched) <https://reviews.apache.org/r/69096/#comment294645> I think we some other create helpers lying around, e.g. createTask. Is this where these belong? Do you think we need them? - Benjamin Mahler On Oct. 20, 2018, 1:28 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69096/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2018, 1:28 a.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > This helps to share the helpers between > `hierarchical_allocator_tests.cpp` and > `hierarchical_allocator_benchmarks.cpp`. > > > Diffs > ----- > > src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81 > src/tests/CMakeLists.txt 00dbdee1c06e7571fa799850cdaf7f2ccadc8bea > src/tests/allocator.hpp 15a5396986ea6939f25b8d23b87a91c27338fc7b > src/tests/allocator.cpp PRE-CREATION > src/tests/hierarchical_allocator_tests.cpp > 27fbd9cf0c4442e7675362a806d35bad141ffb6d > > > Diff: https://reviews.apache.org/r/69096/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
