----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69176/#review210110 -----------------------------------------------------------
Ship it! Good catch! Do you want to ship this (have your gotten your commit bits?), or shall I? - Joseph Wu On Oct. 25, 2018, 4:11 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69176/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 4:11 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-8343 > https://issues.apache.org/jira/browse/MESOS-8343 > > > Repository: mesos > > > Description > ------- > > The test was flaky due to race between scheduler driver stopping > during test teardown and the scheduler `error()` invocation. > Adding the missing synchronization for the expectation should > eliminate the race. > > > Diffs > ----- > > src/tests/scheduler_http_api_tests.cpp > 64c000650acab30647d0c1e7d685bec954aa7118 > > > Diff: https://reviews.apache.org/r/69176/diff/1/ > > > Testing > ------- > > ran `chedulerHttpApiTest.UpdatePidToHttpScheduler` continously without > failure. > > > Thanks, > > Meng Zhu > >
