> On Oct. 23, 2018, 2:51 p.m., James DeFelice wrote: > > include/mesos/mesos.proto > > Lines 2030 (patched) > > <https://reviews.apache.org/r/69036/diff/4/?file=2101986#file2101986line2030> > > > > Referring to an implementation artifact like the "disk profile adaptor" > > seems strange in this context. Perhaps re-word this? > > > > Instead of: > > > has been removed by the disk profile adaptor > > > > Maybe something like this instead? > > > is no longer known by Mesos
The "disk profile adaptor" is a public module interface in Mesos so I was trying to be explicit. WDYT? - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/#review209920 ----------------------------------------------------------- On Oct. 23, 2018, 2:37 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69036/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2018, 2:37 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-9275 > https://issues.apache.org/jira/browse/MESOS-9275 > > > Repository: mesos > > > Description > ------- > > The semantics of these two operations has been updated to provide > primitives to import CSI volumes and recover CSI volumes against agent > ID changes and metadata loss. > > > Diffs > ----- > > include/mesos/mesos.proto 5a985fca39cdfb7e9b4775650a7e5dbe68c3b8ae > include/mesos/v1/mesos.proto a5ebb786a98bd3fd34745ddc553aa7a751c0e337 > > > Diff: https://reviews.apache.org/r/69036/diff/4/ > > > Testing > ------- > > Test will be done later in the chain. > > > Thanks, > > Chun-Hung Hsiao > >
