----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69237/#review210303 -----------------------------------------------------------
Ship it! Ship It! - Kevin Klues On Nov. 1, 2018, 10:28 nachm., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69237/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2018, 10:28 nachm.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > ------- > > The test was previously using '.strip()' to compare the command stdout > and the result we expect. By replacing the task command to use 'printf' > instead of 'echo', we are able to simplify this assertion. > > > Diffs > ----- > > src/python/cli_new/lib/cli/tests/task.py > ce3a55d4b66ca74b6be892d058644281ee5c803d > > > Diff: https://reviews.apache.org/r/69237/diff/2/ > > > Testing > ------- > > ``` > (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests > Running the Mesos CLI unit tests > > TestAgentPlugin > test_list (cli.tests.agent.TestAgentPlugin) ... ok > > TestInfrastructure > test_capture_output (cli.tests.tests.TestInfrastructure) ... ok > test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok > > TestTaskPlugin > test_exec (cli.tests.task.TestTaskPlugin) ... ok > test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok > test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok > test_list (cli.tests.task.TestTaskPlugin) ... ok > > ---------------------------------------------------------------------- > Ran 7 tests in 17.238s > > OK > ``` > > > Thanks, > > Armand Grillet > >
