----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69362/#review210715 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/storage/provider.cpp Line 2833 (original), 2851 (patched) <https://reviews.apache.org/r/69362/#comment295450> Any reason we cannot use a simpler and more familiar lambda (which captures `volumeAttributes`?), e.g., ``` // ... .then(defer( self(), [=](const csi::v0::ValidateVolumeCapabilitiesResponse& response) -> Future<Nothing> { // Body. })); // ... ``` - Benjamin Bannier On Nov. 20, 2018, 12:30 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69362/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2018, 12:30 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-9275 > https://issues.apache.org/jira/browse/MESOS-9275 > > > Repository: mesos > > > Description > ------- > > The parameters of CSI volumes created by SLRPs are now checkpointed, and > used to validate volumes created from previous SLRP runs. > > > Diffs > ----- > > src/csi/state.proto 8445399ac17cfef740c2523172b34fd5439f2d3a > src/resource_provider/storage/provider.cpp > c137fa4f13edc58d93c03a9dd32fdf9d38b38316 > > > Diff: https://reviews.apache.org/r/69362/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
