----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69411/#review210720 -----------------------------------------------------------
PASS: Mesos patch 69411 was successfully built and tested. Reviews applied: `['69411']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2630/mesos-review-69411 - Mesos Reviewbot Windows On Nov. 20, 2018, 2:20 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69411/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2018, 2:20 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > This review adds a new method `cluster::Master::create()` that > allows constructing masters while only specifying the non-standard > components required for the specific test, like this: > > auto master = cluster::Master::build() > .withZookeeperUrl(url) > .withAllocator(allocator); > > This is sometimes better known as "fluent interface". > > > Diffs > ----- > > src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 > src/tests/cluster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0 > > > Diff: https://reviews.apache.org/r/69411/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >