----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69405/#review210723 -----------------------------------------------------------
Fix it, then Ship it! Lovely! src/common/authorization.hpp Lines 34 (patched) <https://reviews.apache.org/r/69405/#comment295456> please move `stout/hashset` include here - Alexander Rukletsov On Nov. 20, 2018, 2:35 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69405/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2018, 2:35 a.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Moves 'createAuthorizationCallbacks' out of common/http into > common/authorization. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > 83944b9a7322707609c2d4e13b84ab3a44cf4e25 > src/common/authorization.hpp PRE-CREATION > src/common/authorization.cpp PRE-CREATION > src/common/http.hpp 6ca54a641d1ea1625c70518f8870516664741e9a > src/common/http.cpp eeeed9703f80880850b8a1ec9ddd2b1e8f125f36 > src/master/main.cpp 2c7b1bb492a0655dec9280e98ff942a15e2ae8f0 > src/slave/main.cpp e774092ff2c3941f17cdebfb26d80c05a26497c6 > src/tests/cluster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0 > src/tests/logging_tests.cpp 30bcdc7f4aa9d6a39c5ef6e825357815bf4f9f19 > > > Diff: https://reviews.apache.org/r/69405/diff/1/ > > > Testing > ------- > > `make check` and internal CI > > > Thanks, > > Till Toenshoff > >
