----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/#review210724 -----------------------------------------------------------
Ship it! Unless you reorder the chain, could you call out in the commit message the we will fix `StorageLocalResourceProviderTest.ImportPreprovisionedVolume` in a follow-up commit? - Benjamin Bannier On Nov. 19, 2018, 10:19 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69360/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2018, 10:19 p.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-9275 > https://issues.apache.org/jira/browse/MESOS-9275 > > > Repository: mesos > > > Description > ------- > > Due to the changes of the `CREATE_DISK` semantics, this test is > rewritten to convert a preprovisioned volume to a profile volumes, and > then to destroy it to return the space back to the storage pool. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 077a46585bd56181ba199dc529e09f38f4971338 > > > Diff: https://reviews.apache.org/r/69360/diff/2/ > > > Testing > ------- > > make check > > This test passes iff the next patch is applied. > > > Thanks, > > Chun-Hung Hsiao > >
