> On Nov. 20, 2018, 1:16 p.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Lines 367-370 (patched) > > <https://reviews.apache.org/r/69364/diff/2/?file=2108861#file2108861line367> > > > > Can we move this block and the one below outside of the conditional or > > do we depend on ordering/side effects?
Currently the returned `ALREADY_EXISTS` status depends on the condition. It can also be argued that returning `INVALID_ARGUMENT` despite the volume exists also conforms to the CSI spec. Let me do that instead. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/#review210711 ----------------------------------------------------------- On Nov. 19, 2018, 11:35 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69364/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2018, 11:35 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-9275 > https://issues.apache.org/jira/browse/MESOS-9275 > > > Repository: mesos > > > Description > ------- > > When the flag is specified, `CreateVolume` and `GetCapacity` work only > if the `parameters` argument matches this flag. This will be used to > test the checkpointing of create parameters of CSI volumes in SLRP. > > > Diffs > ----- > > src/examples/test_csi_plugin.cpp 66f4ee0e2381e94bf9110d1e6e9f79eac939f683 > > > Diff: https://reviews.apache.org/r/69364/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
