----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review210838 -----------------------------------------------------------
Fix it, then Ship it! Thanks for adding this Benjamin - also thanks James for reviewing! src/posix/rlimits.cpp Line 130 (original), 130 (patched) <https://reviews.apache.org/r/67136/#comment295597> Thanks for fixing this! src/posix/rlimits.cpp Lines 140 (patched) <https://reviews.apache.org/r/67136/#comment295596> Let's kill this blank OR add more blsnks to the rest to make the entire picture a bit more consistent. Adjusting while committing - leaving this open for your entertainment. - Till Toenshoff On May 18, 2018, 12:36 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67136/ > ----------------------------------------------------------- > > (Updated May 18, 2018, 12:36 p.m.) > > > Review request for mesos, Jie Yu and James Peach. > > > Repository: mesos > > > Description > ------- > > Added a function to get rlimits. > > > Diffs > ----- > > src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da > src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d > > > Diff: https://reviews.apache.org/r/67136/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
