----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69458/#review210898 -----------------------------------------------------------
PASS: Mesos patch 69458 was successfully built and tested. Reviews applied: `['69157', '69458']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2654/mesos-review-69458 - Mesos Reviewbot Windows On Nov. 27, 2018, 5:59 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69458/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2018, 5:59 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan > Schlicht. > > > Repository: mesos > > > Description > ------- > > When the agent handles an `UpdateOperationStatusMessage` from a resource > provider, it injects its own ID which is (at least conceptually) unknown > to the resource provider before forwarding the message to the master, > and also updates its own tracking for the operation. > > This patch makes sure that we first mutate the message before handing it > on for updating the internal operation tracking, while previously we > used the unmodified message. Always using the same message reduces error > potential if in future changes we e.g., introduce agent operation status > update managers. > > > Diffs > ----- > > src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb > > > Diff: https://reviews.apache.org/r/69458/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
