----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69452/#review210905 -----------------------------------------------------------
Ship it! Thanks for the test! Have you run it in repetition to make sure it's not flaky? Left some suggestions below. src/tests/master_tests.cpp Lines 3845 (patched) <https://reviews.apache.org/r/69452/#comment295723> s/frameworks that have not re-registered/recovered (but not yet re-registered) frameworks/ src/tests/master_tests.cpp Lines 3846 (patched) <https://reviews.apache.org/r/69452/#comment295724> s/messages to their frameworks/executor->framework messages/ src/tests/master_tests.cpp Lines 3848-3849 (patched) <https://reviews.apache.org/r/69452/#comment295725> Probably this could be a bit clearer: that in the pid case the agent bypasses the master and directly sends to the scheduler driver. src/tests/master_tests.cpp Lines 3850 (patched) <https://reviews.apache.org/r/69452/#comment295730> Maybe a TODO to simplify this test by having a test scheduler that knows how to launch a mock executor? src/tests/master_tests.cpp Lines 3861 (patched) <https://reviews.apache.org/r/69452/#comment295727> executorConnected? src/tests/master_tests.cpp Lines 3974-3976 (patched) <https://reviews.apache.org/r/69452/#comment295731> Maybe settle at the end anyway, so that we start calling destructors after the message finishes processing? Right now it will start after the message starts processing. src/tests/mesos.hpp Line 907 (original), 919 (patched) <https://reviews.apache.org/r/69452/#comment295726> just curious, what happened here? seems like this should be a different patch? - Benjamin Mahler On Nov. 27, 2018, 4:58 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69452/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2018, 4:58 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, > and Till Toenshoff. > > > Bugs: MESOS-9419 > https://issues.apache.org/jira/browse/MESOS-9419 > > > Repository: mesos > > > Description > ------- > > This patch adds the `ExecutorMessageToRecoveredHttpFramework` test to > ensure that a master will not crash when forwarding an executor message > to a recovered framework to prevent any future regression of MESOS-9419. > > > Diffs > ----- > > src/tests/master_tests.cpp 651bb9ba9298fc3d7179ed86487aa55be519ce12 > src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e > > > Diff: https://reviews.apache.org/r/69452/diff/1/ > > > Testing > ------- > > make check > > This test will fail without r/69451. > > > Thanks, > > Chun-Hung Hsiao > >
