----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69162/#review210935 -----------------------------------------------------------
Fix it, then Ship it! In commit message: s/This patch add agent and resource provide IDs to/This patch adds agent and resource provider IDs to/ include/mesos/mesos.proto Lines 2401-2403 (patched) <https://reviews.apache.org/r/69162/#comment295784> I would be explicit here that if both fields are unset, then `uuid` should be unset also. - Greg Mann On Nov. 27, 2018, 6:03 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69162/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2018, 6:03 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice. > > > Bugs: MESOS-9293 > https://issues.apache.org/jira/browse/MESOS-9293 > > > Repository: mesos > > > Description > ------- > > This patch add agent and resource provide IDs to > `UpdateOperationStatus` and `UpdateOperationStatusMessage`. With that > frameworks are able to reconcile enough information after failover to > construct operation acknowledgements. > > We will add code to populate these fields in a follow-up patch. > > > Diffs > ----- > > include/mesos/mesos.proto 56107f47a46ac3679a57af0580c55ad0f98543f5 > include/mesos/v1/mesos.proto c6e7515a44eca0b057725c7b8196250072b56be5 > src/common/type_utils.cpp ef13eae47b88efc15f1b2d00852b6387c2fffcbc > src/internal/devolve.cpp 491ed2aa131a92e958bfa71cccfc5f257cd4b3f9 > src/internal/evolve.cpp aa60efed5a28ed4d847a4a27aa8e994cda82175d > > > Diff: https://reviews.apache.org/r/69162/diff/6/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
