----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69412/#review210906 -----------------------------------------------------------
Fix it, then Ship it! The test itself appears a bit wonky and not really deterministic. Let's simply not have that test in here - please remove it and I will commit immediately. 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 18 (patched) <https://reviews.apache.org/r/69412/#comment295728> Alphabetize please. 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 464 (patched) <https://reviews.apache.org/r/69412/#comment295729> s/Thread/thread/ - Till Toenshoff On Nov. 20, 2018, 2:51 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69412/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2018, 2:51 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, Jan Schlicht, and Till > Toenshoff. > > > Bugs: MESOS-9411 > https://issues.apache.org/jira/browse/MESOS-9411 > > > Repository: mesos > > > Description > ------- > > The old implementation of the OpenSSl utilities which computes an HMAC > 256 signature makes a non thread safe call to the OpenSSL library. > > This is addressed in this patch. It also includes a test which will > cause the shared buffer to be rewritten if the non thread safe code is > executed. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/utilities.cpp > 72ad07954308db3e67c75d0fc08d46095192caca > 3rdparty/libprocess/src/tests/jwt_tests.cpp > 11ada99a971e2a8c74c3a1060a25955cc0bdeac5 > > > Diff: https://reviews.apache.org/r/69412/diff/1/ > > > Testing > ------- > > make -j12 check > > > Thanks, > > Alexander Rojas > >
