----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68138/#review211024 -----------------------------------------------------------
Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp Lines 1702 (patched) <https://reviews.apache.org/r/68138/#comment295874> Maybe: QuotaAccountingReserveAllocatedResources? src/tests/hierarchical_allocator_tests.cpp Lines 1712 (patched) <https://reviews.apache.org/r/68138/#comment295872> isn't the quota setting above this comment? src/tests/hierarchical_allocator_tests.cpp Lines 1751-1761 (patched) <https://reviews.apache.org/r/68138/#comment295873> The way this test is written only catches the case where making the reservation could double-charge the quota, but it doesn't catch a bug where the reservation would lead to no-charge of the quota. One way to resolve this easily is to make the second agent larger, in order to make sure that the allocation is getting chopped to match the unsatisfied quota exactly. src/tests/hierarchical_allocator_tests.cpp Lines 1767 (patched) <https://reviews.apache.org/r/68138/#comment295875> Maybe: QuotaAccountingUnreserveAllocatedResources? src/tests/hierarchical_allocator_tests.cpp Lines 1775 (patched) <https://reviews.apache.org/r/68138/#comment295876> Ditto here, the quota setting is actually above this comment? - Benjamin Mahler On Sept. 21, 2018, 10:52 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68138/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 10:52 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Bugs: MESOS-9099 > https://issues.apache.org/jira/browse/MESOS-9099 > > > Repository: mesos > > > Description > ------- > > Added two allocator tests to ensure reserving and > unreserving allocated resources do not affect > quota accounting. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 27fbd9cf0c4442e7675362a806d35bad141ffb6d > > > Diff: https://reviews.apache.org/r/68138/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
