----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/#review211067 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 8539-8541 (original) <https://reviews.apache.org/r/69505/#comment295934> Should we replace this with something like the following? ``` CHECK(!resourceProviderId.isError()) << "Could not determine resource provider of operation " << *operation << ": " << resourceProviderId.error(); ``` src/tests/slave_tests.cpp Lines 6505-6507 (patched) <https://reviews.apache.org/r/69505/#comment295936> These checks seem redundant and unrelated to this test? - Gastón Kleiman On Dec. 4, 2018, 2:22 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69505/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2018, 2:22 p.m.) > > > Review request for mesos, Benno Evers and Gastón Kleiman. > > > Bugs: MESOS-9278 > https://issues.apache.org/jira/browse/MESOS-9278 > > > Repository: mesos > > > Description > ------- > > This patch adds an operation status update manager to the agent > in order to handle updates for operations on agent default > resources. A new test is also added which verifies that such > updates are retried. > > > Diffs > ----- > > src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e > src/slave/slave.hpp edf7269d4057ec8c95bb54c855210ad00d002a50 > src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb > src/tests/slave_tests.cpp 1e918712d73d0a03c4c15b41babff1f649ba9c07 > > > Diff: https://reviews.apache.org/r/69505/diff/1/ > > > Testing > ------- > > `bin/mesos-tests.sh --gtest_filter="*UpdateOperationStatusRetry*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
