----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211146 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/linux_filesystem_isolator_tests.cpp Lines 137 (patched) <https://reviews.apache.org/r/69540/#comment296078> As a separate commit, can we factor out the flags set up from all these test case? src/tests/containerizer/linux_filesystem_isolator_tests.cpp Lines 156 (patched) <https://reviews.apache.org/r/69540/#comment296082> Writing to /dev/full should fail with ENOSPC, but I don't see a straightforward way to verify that with dd. - James Peach On Dec. 10, 2018, 4:41 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69540/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2018, 4:41 p.m.) > > > Review request for mesos, Jie Yu and James Peach. > > > Bugs: MESOS-9462 > https://issues.apache.org/jira/browse/MESOS-9462 > > > Repository: mesos > > > Description > ------- > > This test verifies that pseudo devices like /dev/random are properly > mounted in the container's root filesystem. > > > Diffs > ----- > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > 84b342cdd4b8ef4803725ecfa9f922687ccdadd8 > src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5 > > > Diff: https://reviews.apache.org/r/69540/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
