----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/ -----------------------------------------------------------
(Updated Dec. 10, 2018, 5:20 p.m.) Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Changes ------- Used an `extern` constant defined in `executor/executor.cpp` instead of hardcoding `Minutes(30)`. Bugs: MESOS-7564 https://issues.apache.org/jira/browse/MESOS-7564 Repository: mesos Description ------- This adds two separate tests which check if the Agent sends heartbeats to HTTP executors, and if the HTTP executor driver sends heartbeats to the agent. Diffs (updated) ----- src/examples/long_lived_executor.cpp b87a8069892b3886329581e86ed15072dd785b3d src/examples/test_http_executor.cpp e5f7cbb3b4e35663717f2a74550f8378bfafb0f9 src/tests/executor_http_api_tests.cpp a635e1a3c228b52f47ba81a67753ea49ce092143 src/tests/mesos.hpp b57bbd40051fed0829453c56b90f5660354f4334 Diff: https://reviews.apache.org/r/69474/diff/6/ Changes: https://reviews.apache.org/r/69474/diff/5-6/ Testing ------- ``` cmake --build . --target check src/mesos-tests --gtest_filter="*Heartbeat*" --verbose --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu