----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66815/#review211188 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/default_executor.cpp Line 938 (original), 939-944 (patched) <https://reviews.apache.org/r/66815/#comment296119> Can we make it a one-liner? For example, ``` LOG(INFO) << "Child container " << container->containerId << " of task '" << taskId << "' completed in state " << stringify(taskState) << (message.isSome() ? ": " + message.get() : ""); ``` - Alexander Rukletsov On April 26, 2018, 3:24 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66815/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 3:24 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8797 > https://issues.apache.org/jira/browse/MESOS-8797 > > > Repository: mesos > > > Description > ------- > > This would fail in some cases where the optional > message is `None`, e.g. when the container is in > killing state. > > > Diffs > ----- > > src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b > > > Diff: https://reviews.apache.org/r/66815/diff/1/ > > > Testing > ------- > > `./src/mesos-tests > --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 > --gtest_repeat=500 --gtest_break_on_failure` > > > Thanks, > > Benno Evers > >
