> On Dec. 17, 2018, 1:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Line 77 (original), 72 (patched) > > <https://reviews.apache.org/r/69559/diff/3/?file=2114076#file2114076line79> > > > > Does this display as JSON?
It doesn't as we go back to the old codebase. > On Dec. 17, 2018, 1:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Lines 118 (patched) > > <https://reviews.apache.org/r/69559/diff/3/?file=2114076#file2114076line127> > > > > Why not > > ``` > > if data: > > ``` > > > > Can we get called with non `str` instances? Yes it happens because `api()` is used in different contexts, without this check the script crashed as we sometimes got data as a `str` when we except `bytes` to use `urllib.request.urlopen`. > On Dec. 17, 2018, 1:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Lines 298 (patched) > > <https://reviews.apache.org/r/69559/diff/3/?file=2114076#file2114076line317> > > > > Does this mean that if a RR changed in the chain that was not the last > > one, that we wont run validate the chain? > > Can you please explain the consequences in the comment? Yes. This limitation existed since a while and is reintroduced by going back to the old code: https://github.com/apache/mesos/commit/d6f8620fd76d24a6e8efe1f6784557189de04f00 - Armand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211355 ----------------------------------------------------------- On Dec. 13, 2018, 4:59 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69559/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2018, 4:59 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Dragos Schebesch, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-9459 > https://issues.apache.org/jira/browse/MESOS-9459 > > > Repository: mesos > > > Description > ------- > > We have switched the Python 2 support scripts to Python 3 a few months > ago. During this transition, 'verify-reviews.py' has been modified, > mainly to work better on Windows: https://reviews.apache.org/r/67505/. > > The Python 3 script has then replaced the Python 2 one and we now face > an issue with the script, MESOS-9459. Due to all the changes made > between the Python 2 and Python 3 scripts, it is hard for us to > know when the script started failing and why. > > To solve this issue, this commit takes the state of 'verify-reviews.py' > as it was in 74121798f24fca372180b8c4bc00b4df07d46240, applies 2to3, > adds the '--out-file' option, then adds the content of: > * ac766c8bd0fba348399d8eac52f75f62e64db64e > * 43eba285cb5c8622a6be8a5bdad637ed53431e85 > * 5b348b6070f0d0403cb69b6a7fa638fc46b7ff49 > * 568fcdfd29788d9df89a51ffae7969c2bf0ea173 > > This gives a clean diff between 74121798f24fca372180b8c4bc00b4df07d46240 > and this commit, fixes the issue raised in MESOS-9459, and does not > remove existing features. However, this uses less our common library > developed in the chain that landed while migrating from Python 2 to 3. > > This should be followed by a refactoring of 'verify-review.py' and > 'common.py' to use our library more while not breaking the script > when using Reviewbot. > > > Diffs > ----- > > support/verify-reviews.py 552dc366a588e6c5ad0efdcdca03d66f1d7044c3 > > > Diff: https://reviews.apache.org/r/69559/diff/3/ > > > Testing > ------- > > Checked https://www.diffchecker.com/R5uYlefc a diff of 'verify-reviews.py' > between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit. > > > ``` > ? apache-mesos (MESOS-9459) ? BUILD_URL=yolo python3 > support/verify-reviews.py -u user -p password > git rev-parse HEAD > Checking if review: 69544 needs verification > Skipping blocking review 69544 > Checking if review: 69342 needs verification > Skipping blocking review 69342 > Checking if review: 69478 needs verification > Skipping blocking review 69478 > Checking if review: 69479 needs verification > Skipping blocking review 69479 > Checking if review: 67997 needs verification > Skipping blocking review 67997 > Checking if review: 68162 needs verification > Skipping blocking review 68162 > Checking if review: 68163 needs verification > Skipping blocking review 68163 > Checking if review: 69071 needs verification > Skipping blocking review 69071 > Checking if review: 68795 needs verification > Skipping blocking review 68795 > Checking if review: 69421 needs verification > Skipping blocking review 69421 > Checking if review: 69422 needs verification > Skipping blocking review 69422 > Checking if review: 69064 needs verification > Skipping blocking review 69064 > Checking if review: 69541 needs verification > Skipping blocking review 69541 > Checking if review: 68018 needs verification > Skipping blocking review 68018 > Checking if review: 68017 needs verification > Skipping blocking review 68017 > Checking if review: 68016 needs verification > Skipping blocking review 68016 > Checking if review: 69551 needs verification > Latest diff timestamp: 2018-12-13 14:20:34 > Verifying review 69551 > Applying review 69551 > /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69551 > Posting review: Bad patch! > > Reviews applied: [69551] > > Failed command: /usr/local/opt/python/bin/python3.7 support/apply-reviews.py > -n -r 69551 > > Error: > 2018-12-14 13:30:42 URL:https://reviews.apache.org/r/69551/diff/raw/ > [52606/52606] -> "69551.patch" [1] > Done processing src/tests/oversubscription_tests.cpp > Done processing src/tests/gc_tests.cpp > Done processing src/tests/containerizer/xfs_quota_tests.cpp > Done processing src/tests/log_tests.cpp > Done processing src/tests/persistent_volume_tests.cpp > Done processing src/tests/master_quota_tests.cpp > Done processing src/tests/partition_tests.cpp > Done processing src/tests/master_slave_reconciliation_tests.cpp > Done processing src/tests/containerizer/mesos_containerizer_tests.cpp > Done processing src/tests/containerizer/port_mapping_tests.cpp > Done processing src/tests/fetcher_tests.cpp > Done processing src/tests/slave_recovery_tests.cpp > Done processing src/tests/rate_limiting_tests.cpp > Done processing src/tests/resource_provider_manager_tests.cpp > Done processing src/tests/fetcher_cache_tests.cpp > Done processing src/tests/scheduler_tests.cpp > Done processing src/tests/utils.hpp > Done processing src/tests/containerizer/linux_filesystem_isolator_tests.cpp > Done processing src/tests/master_authorization_tests.cpp > Done processing src/tests/slave_tests.cpp > Done processing src/tests/master_tests.cpp > Done processing src/tests/storage_local_resource_provider_tests.cpp > Done processing src/tests/hierarchical_allocator_tests.cpp > Done processing src/tests/utils.cpp > ************* Module verify-reviews > support/verify-reviews.py:165:4: W0612: Unused variable 'review_url' > (unused-variable) > support/verify-reviews.py:166:4: W0612: Unused variable 'data' > (unused-variable) > Total errors found: 2 > Checking 24 C++ files > Checking 1 Python file > > Full log: console > git clean -fd > git reset --hard 343cf1e8a8f976b461d4bc05960e8e7019ea3d9f > > Checking if review: 69559 needs verification > Latest diff timestamp: 2018-12-13 13:27:51 > Verifying review 69559 > Applying review 69559 > /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69559 > Posting review: Bad patch! > > Reviews applied: [69559] > > Failed command: /usr/local/opt/python/bin/python3.7 support/apply-reviews.py > -n -r 69559 > > Error: > 2018-12-14 13:31:16 URL:https://reviews.apache.org/r/69559/diff/raw/ > [15662/15662] -> "69559.patch" [1] > error: patch failed: support/verify-reviews.py:33 > error: support/verify-reviews.py: patch does not apply > > Full log: console > git clean -fd > git reset --hard 343cf1e8a8f976b461d4bc05960e8e7019ea3d9f > > Checking if review: 69337 needs verification > Skipping blocking review 69337 > Checking if review: 69547 needs verification > Latest diff timestamp: 2018-12-11 12:15:07 > Latest review timestamp: 2018-12-13 14:04:52 > Checking if review: 69338 needs verification > Latest diff timestamp: 2018-12-13 13:50:29 > Verifying review 69338 > Dependent review: https://reviews.apache.org/api/review-requests/69337/ > Applying review 69337 > /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69337 > Applying review 69338 > /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69338 > + : ubuntu:14.04 > + : autotools > + : gcc > + : --verbose --disable-libtool-wrappers > + : GLOG_v=1 MESOS_VERBOSE=1 > + : 6 > +++ dirname ./support/docker-build.sh > ++ cd ./support/.. > ++ pwd > + MESOS_DIRECTORY=/Users/Armand/Code/apache-mesos > + cd /Users/Armand/Code/apache-mesos > + DOCKERFILE=Dockerfile > + rm -f Dockerfile > + case $OS in > + append_dockerfile 'FROM ubuntu:14.04' > + echo FROM ubuntu:14.04 > + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' > + echo RUN rm -rf '/var/lib/apt/lists/*' > ++ uname -m > + '[' x86_64 = x86_64 ']' > + CLANG_PKG=clang-3.5 > + append_dockerfile 'RUN apt-get update' > + echo RUN apt-get update > + append_dockerfile 'RUN apt-get install -y build-essential clang-3.5 git > maven autoconf libtool software-properties-common' > + echo RUN apt-get install -y build-essential clang-3.5 git maven autoconf > libtool software-properties-common > + append_dockerfile 'RUN apt-get install -y python-dev python-six > libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev' > + echo RUN apt-get install -y python-dev python-six libcurl4-nss-dev > libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev > + append_dockerfile 'RUN apt-get install -y wget curl sed' > + echo RUN apt-get install -y wget curl sed > + case $OS in > + append_dockerfile 'RUN apt-get install -y openjdk-7-jdk' > + echo RUN apt-get install -y openjdk-7-jdk > + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos' > + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos > + append_dockerfile 'RUN curl -sSL > https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o > /tmp/install-cmake.sh' > + echo RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh > -o /tmp/install-cmake.sh > + append_dockerfile 'RUN chmod u+x /tmp/install-cmake.sh && sync && > /tmp/install-cmake.sh --skip-license --prefix=/usr/local' > + echo RUN chmod u+x /tmp/install-cmake.sh '&&' sync '&&' > /tmp/install-cmake.sh --skip-license --prefix=/usr/local > + case $COMPILER in > + append_dockerfile 'ENV CC gcc' > + echo ENV CC gcc > + append_dockerfile 'ENV CXX g++' > + echo ENV CXX g++ > + append_dockerfile 'WORKDIR mesos' > + echo WORKDIR mesos > + append_dockerfile 'COPY . /mesos/' > + echo COPY . /mesos/ > + append_dockerfile 'RUN chown -R mesos /mesos' > + echo RUN chown -R mesos /mesos > + append_dockerfile 'USER mesos' > + echo USER mesos > + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml' > + echo ENV GTEST_OUTPUT xml:report.xml > + append_dockerfile 'ENV DISTCHECK_CONFIGURE_FLAGS --verbose > --disable-libtool-wrappers' > + echo ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers > + append_dockerfile 'ENV GLOG_v=1 MESOS_VERBOSE=1' > + echo ENV GLOG_v=1 MESOS_VERBOSE=1 > + '[' -n '' ']' > + case $BUILDTOOL in > + append_dockerfile 'CMD ./bootstrap && ./configure --verbose > --disable-libtool-wrappers && make -j6 distcheck 2>&1' > + echo CMD ./bootstrap '&&' ./configure --verbose --disable-libtool-wrappers > '&&' make -j6 distcheck '2>&1' > ++ date +%s > + TAG=mesos-1544790698-13934 > + docker build --no-cache=true -t mesos-1544790698-13934 . > Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the > docker daemon running? > Posting review: Bad patch! > > Reviews applied: [69337, 69338] > > Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' > BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose > --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; > ./support/docker-build.sh 2>&1 | tee build_69338"] > > Error: > + : ubuntu:14.04 > + : autotools > + : gcc > + : --verbose --disable-libtool-wrappers > + : GLOG_v=1 MESOS_VERBOSE=1 > + : 6 > +++ dirname ./support/docker-build.sh > ++ cd ./support/.. > ++ pwd > + MESOS_DIRECTORY=/Users/Armand/Code/apache-mesos > + cd /Users/Armand/Code/apache-mesos > + DOCKERFILE=Dockerfile > + rm -f Dockerfile > + case $OS in > + append_dockerfile 'FROM ubuntu:14.04' > + echo FROM ubuntu:14.04 > + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' > + echo RUN rm -rf '/var/lib/apt/lists/*' > ++ uname -m > + '[' x86_64 = x86_64 ']' > + CLANG_PKG=clang-3.5 > + append_dockerfile 'RUN apt-get update' > + echo RUN apt-get update > + append_dockerfile 'RUN apt-get install -y build-essential clang-3.5 git > maven autoconf libtool software-properties-common' > + echo RUN apt-get install -y build-essential clang-3.5 git maven autoconf > libtool software-properties-common > + append_dockerfile 'RUN apt-get install -y python-dev python-six > libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev' > + echo RUN apt-get install -y python-dev python-six libcurl4-nss-dev > libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev > + append_dockerfile 'RUN apt-get install -y wget curl sed' > + echo RUN apt-get install -y wget curl sed > + case $OS in > + append_dockerfile 'RUN apt-get install -y openjdk-7-jdk' > + echo RUN apt-get install -y openjdk-7-jdk > + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos' > + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos > + append_dockerfile 'RUN curl -sSL > https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o > /tmp/install-cmake.sh' > + echo RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh > -o /tmp/install-cmake.sh > + append_dockerfile 'RUN chmod u+x /tmp/install-cmake.sh && sync && > /tmp/install-cmake.sh --skip-license --prefix=/usr/local' > + echo RUN chmod u+x /tmp/install-cmake.sh '&&' sync '&&' > /tmp/install-cmake.sh --skip-license --prefix=/usr/local > + case $COMPILER in > + append_dockerfile 'ENV CC gcc' > + echo ENV CC gcc > + append_dockerfile 'ENV CXX g++' > + echo ENV CXX g++ > + append_dockerfile 'WORKDIR mesos' > + echo WORKDIR mesos > + append_dockerfile 'COPY . /mesos/' > + echo COPY . /mesos/ > + append_dockerfile 'RUN chown -R mesos /mesos' > + echo RUN chown -R mesos /mesos > + append_dockerfile 'USER mesos' > + echo USER mesos > + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml' > + echo ENV GTEST_OUTPUT xml:report.xml > + append_dockerfile 'ENV DISTCHECK_CONFIGURE_FLAGS --verbose > --disable-libtool-wrappers' > + echo ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers > + append_dockerfile 'ENV GLOG_v=1 MESOS_VERBOSE=1' > + echo ENV GLOG_v=1 MESOS_VERBOSE=1 > + '[' -n '' ']' > + case $BUILDTOOL in > + append_dockerfile 'CMD ./bootstrap && ./configure --verbose > --disable-libtool-wrappers && make -j6 distcheck 2>&1' > + echo CMD ./bootstrap '&&' ./configure --verbose --disable-libtool-wrappers > '&&' make -j6 distcheck '2>&1' > ++ date +%s > + TAG=mesos-1544790698-13934 > + docker build --no-cache=true -t mesos-1544790698-13934 . > Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the > docker daemon running? > > Full log: console > git clean -fd > git reset --hard 343cf1e8a8f976b461d4bc05960e8e7019ea3d9f > > Checking if review: 69563 needs verification > Latest diff timestamp: 2018-12-14 01:54:43 > Verifying review 69563 > Applying review 69563 > /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69563 > + : ubuntu:14.04 > + : autotools > + : gcc > + : --verbose --disable-libtool-wrappers > + : GLOG_v=1 MESOS_VERBOSE=1 > + : 6 > +++ dirname ./support/docker-build.sh > ++ cd ./support/.. > ++ pwd > + MESOS_DIRECTORY=/Users/Armand/Code/apache-mesos > + cd /Users/Armand/Code/apache-mesos > + DOCKERFILE=Dockerfile > + rm -f Dockerfile > + case $OS in > + append_dockerfile 'FROM ubuntu:14.04' > + echo FROM ubuntu:14.04 > + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' > + echo RUN rm -rf '/var/lib/apt/lists/*' > ++ uname -m > + '[' x86_64 = x86_64 ']' > + CLANG_PKG=clang-3.5 > + append_dockerfile 'RUN apt-get update' > + echo RUN apt-get update > + append_dockerfile 'RUN apt-get install -y build-essential clang-3.5 git > maven autoconf libtool software-properties-common' > + echo RUN apt-get install -y build-essential clang-3.5 git maven autoconf > libtool software-properties-common > + append_dockerfile 'RUN apt-get install -y python-dev python-six > libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev' > + echo RUN apt-get install -y python-dev python-six libcurl4-nss-dev > libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev > + append_dockerfile 'RUN apt-get install -y wget curl sed' > + echo RUN apt-get install -y wget curl sed > + case $OS in > + append_dockerfile 'RUN apt-get install -y openjdk-7-jdk' > + echo RUN apt-get install -y openjdk-7-jdk > + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos' > + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos > + append_dockerfile 'RUN curl -sSL > https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o > /tmp/install-cmake.sh' > + echo RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh > -o /tmp/install-cmake.sh > + append_dockerfile 'RUN chmod u+x /tmp/install-cmake.sh && sync && > /tmp/install-cmake.sh --skip-license --prefix=/usr/local' > + echo RUN chmod u+x /tmp/install-cmake.sh '&&' sync '&&' > /tmp/install-cmake.sh --skip-license --prefix=/usr/local > + case $COMPILER in > + append_dockerfile 'ENV CC gcc' > + echo ENV CC gcc > + append_dockerfile 'ENV CXX g++' > + echo ENV CXX g++ > + append_dockerfile 'WORKDIR mesos' > + echo WORKDIR mesos > + append_dockerfile 'COPY . /mesos/' > + echo COPY . /mesos/ > + append_dockerfile 'RUN chown -R mesos /mesos' > + echo RUN chown -R mesos /mesos > + append_dockerfile 'USER mesos' > + echo USER mesos > + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml' > + echo ENV GTEST_OUTPUT xml:report.xml > + append_dockerfile 'ENV DISTCHECK_CONFIGURE_FLAGS --verbose > --disable-libtool-wrappers' > + echo ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers > + append_dockerfile 'ENV GLOG_v=1 MESOS_VERBOSE=1' > + echo ENV GLOG_v=1 MESOS_VERBOSE=1 > + '[' -n '' ']' > + case $BUILDTOOL in > + append_dockerfile 'CMD ./bootstrap && ./configure --verbose > --disable-libtool-wrappers && make -j6 distcheck 2>&1' > + echo CMD ./bootstrap '&&' ./configure --verbose --disable-libtool-wrappers > '&&' make -j6 distcheck '2>&1' > ++ date +%s > + TAG=mesos-1544790714-31615 > + docker build --no-cache=true -t mesos-1544790714-31615 . > Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the > docker daemon running? > Posting review: Bad patch! > > Reviews applied: [69563] > > Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' > BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose > --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; > ./support/docker-build.sh 2>&1 | tee build_69563"] > > Error: > + : ubuntu:14.04 > + : autotools > + : gcc > + : --verbose --disable-libtool-wrappers > + : GLOG_v=1 MESOS_VERBOSE=1 > + : 6 > +++ dirname ./support/docker-build.sh > ++ cd ./support/.. > ++ pwd > + MESOS_DIRECTORY=/Users/Armand/Code/apache-mesos > + cd /Users/Armand/Code/apache-mesos > + DOCKERFILE=Dockerfile > + rm -f Dockerfile > + case $OS in > + append_dockerfile 'FROM ubuntu:14.04' > + echo FROM ubuntu:14.04 > + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' > + echo RUN rm -rf '/var/lib/apt/lists/*' > ++ uname -m > + '[' x86_64 = x86_64 ']' > + CLANG_PKG=clang-3.5 > + append_dockerfile 'RUN apt-get update' > + echo RUN apt-get update > + append_dockerfile 'RUN apt-get install -y build-essential clang-3.5 git > maven autoconf libtool software-properties-common' > + echo RUN apt-get install -y build-essential clang-3.5 git maven autoconf > libtool software-properties-common > + append_dockerfile 'RUN apt-get install -y python-dev python-six > libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev' > + echo RUN apt-get install -y python-dev python-six libcurl4-nss-dev > libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev > + append_dockerfile 'RUN apt-get install -y wget curl sed' > + echo RUN apt-get install -y wget curl sed > + case $OS in > + append_dockerfile 'RUN apt-get install -y openjdk-7-jdk' > + echo RUN apt-get install -y openjdk-7-jdk > + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos' > + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos > + append_dockerfile 'RUN curl -sSL > https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o > /tmp/install-cmake.sh' > + echo RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh > -o /tmp/install-cmake.sh > + append_dockerfile 'RUN chmod u+x /tmp/install-cmake.sh && sync && > /tmp/install-cmake.sh --skip-license --prefix=/usr/local' > + echo RUN chmod u+x /tmp/install-cmake.sh '&&' sync '&&' > /tmp/install-cmake.sh --skip-license --prefix=/usr/local > + case $COMPILER in > + append_dockerfile 'ENV CC gcc' > + echo ENV CC gcc > + append_dockerfile 'ENV CXX g++' > + echo ENV CXX g++ > + append_dockerfile 'WORKDIR mesos' > + echo WORKDIR mesos > + append_dockerfile 'COPY . /mesos/' > + echo COPY . /mesos/ > + append_dockerfile 'RUN chown -R mesos /mesos' > + echo RUN chown -R mesos /mesos > + append_dockerfile 'USER mesos' > + echo USER mesos > + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml' > + echo ENV GTEST_OUTPUT xml:report.xml > + append_dockerfile 'ENV DISTCHECK_CONFIGURE_FLAGS --verbose > --disable-libtool-wrappers' > + echo ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers > + append_dockerfile 'ENV GLOG_v=1 MESOS_VERBOSE=1' > + echo ENV GLOG_v=1 MESOS_VERBOSE=1 > + '[' -n '' ']' > + case $BUILDTOOL in > + append_dockerfile 'CMD ./bootstrap && ./configure --verbose > --disable-libtool-wrappers && make -j6 distcheck 2>&1' > + echo CMD ./bootstrap '&&' ./configure --verbose --disable-libtool-wrappers > '&&' make -j6 distcheck '2>&1' > ++ date +%s > + TAG=mesos-1544790714-31615 > + docker build --no-cache=true -t mesos-1544790714-31615 . > Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the > docker daemon running? > > Full log: console > git clean -fd > git reset --hard 343cf1e8a8f976b461d4bc05960e8e7019ea3d9f > > Checking if review: 69557 needs verification > Latest diff timestamp: 2018-12-12 11:16:24 > Latest review timestamp: 2018-12-14 12:22:58 > Checking if review: 69445 needs verification > Latest diff timestamp: 2018-12-12 20:44:05 > Latest review timestamp: 2018-12-14 12:23:02 > Checking if review: 69436 needs verification > Latest diff timestamp: 2018-11-22 19:40:46 > Latest review timestamp: 2018-12-14 12:23:16 > 4 review requests need verification > 69551 > 69559 > 69338 > 69563 > git clean -fd > git reset --hard 343cf1e8a8f976b461d4bc05960e8e7019ea3d9f > ``` > > > Thanks, > > Armand Grillet > >