----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69584/ -----------------------------------------------------------
(Updated Dec. 18, 2018, 2:59 p.m.) Review request for mesos and Meng Zhu. Changes ------- Generalized changes to other test filters. Summary (updated) ----------------- Relaxed matching criteria for test filters. Repository: mesos Description (updated) ------- Changed the benchmark filter to remove the required trailing underscore, e.g. the `BenchmarkFilter` would now match all test names containing the string `BENCHMARK`, as opposed to `BENCHMARK_`. The latter filter would fail to match test names like `HierarchicalAllocations_BENCHMARK.MultiFrameworkAllocations`, contrary to the test authors assumptions. This change is also safe regarding false positives, since our naming conventions forbid the matched strings from appearing naturally in any test name. Diffs (updated) ----- src/tests/environment.cpp 03f8f5971b1e91e62ecfbf965028e6f2388d2a7b Diff: https://reviews.apache.org/r/69584/diff/2/ Changes: https://reviews.apache.org/r/69584/diff/1-2/ Testing ------- Thanks, Benno Evers
