----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69581/#review211415 -----------------------------------------------------------
Ship it! Ship It! - Gastón Kleiman On Dec. 18, 2018, 1:06 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69581/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2018, 1:06 a.m.) > > > Review request for mesos, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, and > Meng Zhu. > > > Bugs: MESOS-9460 > https://issues.apache.org/jira/browse/MESOS-9460 > > > Repository: mesos > > > Description > ------- > > Upon receipt of an operation via the operator API, the > master would previously update the allocator and then > update its `Slave` struct in two different continuations. > This created the possibility that the allocator could be > updated in between those two continuations, leading to > inconsistency between the allocator state and the > master's state. > > This patch invokes these two blocks of code > synchronously to avoid this issue. > > > Diffs > ----- > > src/master/master.cpp ae5b24093156a6ba8ffa3e94a46e600eb4def5fa > > > Diff: https://reviews.apache.org/r/69581/diff/1/ > > > Testing > ------- > > Ran the test in the subsequent patch both before and after this fix. Before > the fix, the test fails reliably. After the fix, the test passes reliably. > > > Thanks, > > Greg Mann > >
