----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69575/#review211460 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 8835 (patched) <https://reviews.apache.org/r/69575/#comment296601> s/OPERTATOR/OPERATOR/ src/master/master.cpp Lines 8852 (patched) <https://reviews.apache.org/r/69575/#comment296603> s/and/an/ src/master/master.cpp Lines 8857 (patched) <https://reviews.apache.org/r/69575/#comment296604> s/Framworks/Frameworks/ src/master/master.cpp Lines 8859 (patched) <https://reviews.apache.org/r/69575/#comment296605> Can we get rid of this local variable? src/tests/api_tests.cpp Lines 4859-4860 (patched) <https://reviews.apache.org/r/69575/#comment296606> Fits on one line. src/tests/api_tests.cpp Lines 4921-4924 (patched) <https://reviews.apache.org/r/69575/#comment296608> Remove one of these newlines. src/tests/api_tests.cpp Lines 4924 (patched) <https://reviews.apache.org/r/69575/#comment296607> Indented too far. - Greg Mann On Dec. 19, 2018, 5:51 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69575/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2018, 5:51 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-8782 > https://issues.apache.org/jira/browse/MESOS-8782 > > > Repository: mesos > > > Description > ------- > > When an agent is marked as gone through the operator api, > notify all frameworks with outstanding offer operations on > that agent that these operations have been transitioned > to `OPERATION_GONE_BY_OPERATOR`. > > > Diffs > ----- > > src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e > src/tests/api_tests.cpp fdd9f871f75617fc26a28679e2a1e41f506c6133 > > > Diff: https://reviews.apache.org/r/69575/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
