----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69697/#review211776 -----------------------------------------------------------
Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 9:30 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69697/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2019, 9:30 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9514 > https://issues.apache.org/jira/browse/MESOS-9514 > > > Repository: mesos > > > Description > ------- > > Reverts the improvements made on the support script `verify-reviews.py` > in 3badf7179992e61f30f5a79da9d481dd451c7c2f. Sadly, these changes have > broken our Azure based Mesos CI as seen in MESOS-9514. > > After comparing the code before and after the commit, we can see that > the line failing in CI, `HEAD = shell("git rev-parse HEAD")`, is > misplaced. It was previously located in the exit process in the > `cleanup()` function and it is now back there, surrounded by a > try/catch for error handling. > > > Diffs > ----- > > support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d > > > Diff: https://reviews.apache.org/r/69697/diff/1/ > > > Testing > ------- > > > Thanks, > > Armand Grillet > >
