----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review211993 -----------------------------------------------------------
src/master/master.cpp Lines 11248 (patched) <https://reviews.apache.org/r/68147/#comment297576> Can you add a comment explaining why it is not necessary to call `allocator->recoverResources(...)` here, and that the `slave->recoverResources(...)` and `framework->recoverResources(...)` below are unrelated and thus the bookkeeping would still be consistent even if `allocator->recoverResources(...)` is not called? src/slave/http.cpp Lines 3310 (patched) <https://reviews.apache.org/r/68147/#comment297577> Please add the following log line here: ``` LOG(INFO) << "Processing MARK_RESOURCE_PROVIDER_GONE for resource provider " << resourceProviderId; ``` src/tests/api_tests.cpp Lines 7877 (patched) <https://reviews.apache.org/r/68147/#comment297580> This is not necessary since the `AWAIT_READY` below enforces the proper synchronization. src/tests/api_tests.cpp Lines 7905 (patched) <https://reviews.apache.org/r/68147/#comment297581> `std::move(endpointDetector)` - Chun-Hung Hsiao On Oct. 25, 2018, 10:47 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68147/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 10:47 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan > Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > This patch adds support for triggering permanent removal of local > resource providers. We also add authorization and tests as part of this > patch. > > > Diffs > ----- > > include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 > include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f21593444467c66ed35ee90aea07f > src/common/protobuf_utils.cpp a45607eed4c4bae5010bcc3f3ffeabd6d911062a > src/master/master.cpp 3b3824a67f46866cd64e32d7f9f92484b5891aa2 > src/slave/http.hpp 5b113fa2f7e3421d4219e0ece113010937b204c1 > src/slave/http.cpp ba389263ef7ab311682d542424eb56360841d24c > src/slave/slave.hpp edf7269d4057ec8c95bb54c855210ad00d002a50 > src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb > src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e > src/tests/api_tests.cpp edde48a4b4b46c9f47bc44de389c97b77322b8e8 > > > Diff: https://reviews.apache.org/r/68147/diff/12/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
