----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review212032 -----------------------------------------------------------
Fix it, then Ship it! LGTM. 3rdparty/grpc-1.10.0.patch Lines 33 (patched) <https://reviews.apache.org/r/69708/#comment297626> Not related to this patch, but I wonder how this was needed given that we didn't patch outside of `WIN32` before. 3rdparty/grpc-1.10.0.patch Lines 64 (patched) <https://reviews.apache.org/r/69708/#comment297625> Does this actually describe what this patch intends to do? You could also expand in the commit message body to make it easier to forward port this should we ever bump to a more recent bundled grpc version. - Benjamin Bannier On Jan. 14, 2019, 10:47 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69708/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2019, 10:47 p.m.) > > > Review request for mesos, Benjamin Bannier, BenjaminVW BenjaminVW, Gastón > Kleiman, Joseph Wu, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-9519 > https://issues.apache.org/jira/browse/MESOS-9519 > > > Repository: mesos > > > Description > ------- > > This patch cherry-picks an unofficial commit to disable ALPN compilation > if only OpenSSL 1.0.1 is on the system. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 703808d063e4bba58f647b5d48b78724003bcc4e > 3rdparty/grpc-1.10.0.patch 655f00387a6b308b653b23053419ec05c8b22144 > 3rdparty/grpc.md e06843c8b6038eb9fb809241686fd611d1daedc8 > > > Diff: https://reviews.apache.org/r/69708/diff/5/ > > > Testing > ------- > > OS=ubuntu:14.04 BUILDTOOL=cmake COMPILER=gcc CONFIGURATION='--verbose > --enable-libevent --enable-ssl' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' > support/docker-build.sh > OS=ubuntu:16.04 BUILDTOOL=cmake COMPILER=gcc CONFIGURATION='--verbose > --enable-libevent --enable-ssl' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' > support/docker-build.sh (to make sure that it works with OpenSSL 1.0.2. Also > manually inspected that ALPN symbols are linked). > Manually tested on Debian 9 to ensure that the CMake rule can find its > OpenSSL 1.1.0. > > NOTE: The patch itself does not depend on r/69725, but the ubuntu:16.04 test > above does. > > > Thanks, > > Chun-Hung Hsiao > >
