> On Jan. 15, 2019, 12:53 p.m., Benjamin Bannier wrote: > > Is this something we should create a JIRA for? I am asking since it could > > have a noticable impact on check performance due to faster loading and a > > candidate for (future) backporting.
Assuming we use the CMake build when deploying Mesos agents, then yes. At the moment, most deployments use the autotools build, so this change wouldn't have any impact on performance. > On Jan. 15, 2019, 12:53 p.m., Benjamin Bannier wrote: > > src/checks/CMakeLists.txt > > Line 20 (original), 20 (patched) > > <https://reviews.apache.org/r/69750/diff/1/?file=2119796#file2119796line20> > > > > While `tcp_connect.cpp` depends on `stout`, we seem to usually rely on > > the deps we declare to pull in other deps for us. Yes. I'll be making a few more changes which push various targets up the build chain (i.e. fewer dependencies). In general, I will be relying on CMake to transitively pull in dependencies of dependencies where it makes sense to. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69750/#review212033 ----------------------------------------------------------- On Jan. 15, 2019, 12:01 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69750/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2019, 12:01 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This binary does not need to be linked to libmesos, as it > only uses some basic stout/libprocess headers. > > > Diffs > ----- > > src/checks/CMakeLists.txt a3a6aed18429979cd43b9d8a7be9753f4bd3feba > > > Diff: https://reviews.apache.org/r/69750/diff/1/ > > > Testing > ------- > > cmake --build . --target mesos-tcp-connect > > > Thanks, > > Joseph Wu > >
