----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69811/#review212241 -----------------------------------------------------------
src/resource_provider/storage/provider.cpp Lines 395 (patched) <https://reviews.apache.org/r/69811/#comment297969> +1 It's not clear why we're doing special things for PROBE vs the other calls. - James DeFelice On Jan. 23, 2019, 7:07 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69811/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2019, 7:07 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9517 > https://issues.apache.org/jira/browse/MESOS-9517 > > > Repository: mesos > > > Description > ------- > > This patch refactors the `StorageLocalResourceProvider::call` function > to obtain the latest service future through `getService` before making > the actual RPC call. The subsequent patch would utilize this to support > RPC retry across plugin restarts. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > d6e20a549ede189c757ae3ae922ab7cb86d2be2c > > > Diff: https://reviews.apache.org/r/69811/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
